----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101354/#review3307 -----------------------------------------------------------
This review has been submitted with commit 89e8f1999cca60ac94e815c4e02611d0baa840e9 by Lamarque V. Souza. - Commit On May 13, 2011, 1:31 p.m., Gökcen Eraslan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101354/ > ----------------------------------------------------------- > > (Updated May 13, 2011, 1:31 p.m.) > > > Review request for Network Management and Lamarque Vieira Souza. > > > Summary > ------- > > 2 things are done with this patch: > > * "System" and "User" keywords are not translatable and hardcoded. There is a > Knm::Connection::scopeAsString method but it's not used in anywhere. Patch > makes use of it and also change this method to use i18ned words. Now I can > see translated uses of System and User words in UI. > > * A little refactoring done in settings/config/manageconnectionwidget.cpp to > remove excessive usage of Knm::Connection::typeAsString. I've used the enum > value of Type to use a switch-case structure instead of string comparison > with if-elses. > > > Diffs > ----- > > libs/internals/connection.h bb7e21b > libs/internals/connection.cpp 7085b1b > settings/config/manageconnectionwidget.cpp 6d3dd44 > > Diff: http://git.reviewboard.kde.org/r/101354/diff > > > Testing > ------- > > I did not encountered with an error. > > > Thanks, > > Gökcen > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
