> On May 22, 2011, 11:21 p.m., Lamarque Vieira Souza wrote: > > vpnplugins/vpnc/vpnc.cpp, line 104 > > <http://git.reviewboard.kde.org/r/101419/diff/1/?file=17707#file17707line104> > > > > This should be hardcoded unless you can garantee all Linux > > distributions, BSD*, Unix, etc store the exececutable in the same directory. > > Lamarque Vieira Souza wrote: > I mean, this should not be hardcoded. > > Rajeesh K Nambiar wrote: > Updated patch (r2) is now looking at /usr/bin, /bin and /usr/local/bin/ > (in that order) to find cisco-decrypt; which I guess would cover most normal > cases. > OpenVpnSettingWidget::OpenVpnSettingWidget is doing something similar, I > guess we would need to update that too. I'll provide a separate patch for > that later. > > Lamarque Vieira Souza wrote: > The patch is good to go, just do the renames I mentioned. Please provides > a version for nm09 branch, since nm09 branch does not use *Persistence > classes anymore this patch is not going to apply cleanly.
I'll try to rebase the patch against nm09 and submit separately. What is the best way to do that? 'git-branch nm09' and apply the patch + modify? - Rajeesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101419/#review3454 ----------------------------------------------------------- On June 2, 2011, 7:56 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101419/ > ----------------------------------------------------------- > > (Updated June 2, 2011, 7:56 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > First stab at VPN connection import/export functionality. Currently > implemented just VPNC Import support. Please review, especially the > VpncUiPluginPrivate part which tries to abstract away cisco password decrypt > function. If the general approach looks good, I'll proceed with this and try > to extend for other VPN methods, as well as export function. > > > This addresses bug 146159. > http://bugs.kde.org/show_bug.cgi?id=146159 > > > Diffs > ----- > > libs/ui/vpnpreferences.cpp 843636c > libs/ui/vpnuiplugin.h 7a13027 > settings/config/CMakeLists.txt 268c23b > settings/config/addeditdeletebuttonset.h f7abef7 > settings/config/addeditdeletebuttonset.cpp 4f3f97a > settings/config/manageconnectionwidget.h 51f60a0 > settings/config/manageconnectionwidget.cpp fdd350b > vpnplugins/novellvpn/novellvpn.h 9e026e2 > vpnplugins/novellvpn/novellvpn.cpp 848b527 > vpnplugins/openvpn/openvpn.h a06b88e > vpnplugins/openvpn/openvpn.cpp 60376ed > vpnplugins/pptp/pptp.h 66ea79a > vpnplugins/pptp/pptp.cpp c311f9f > vpnplugins/strongswan/strongswan.h fcd5bde > vpnplugins/strongswan/strongswan.cpp 5bffc2b > vpnplugins/vpnc/nm-vpnc-service.h e3f859a > vpnplugins/vpnc/vpnc.h aec2136 > vpnplugins/vpnc/vpnc.cpp deb9108 > > Diff: http://git.reviewboard.kde.org/r/101419/diff > > > Testing > ------- > > Tested against latest git snapshot, with KDE SC 4.6.3 > > > Thanks, > > Rajeesh > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
