----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103921/#review10503 -----------------------------------------------------------
This review has been submitted with commit 79bd5d65b76a82583e75407db99499ef273f5224 by Lamarque V. Souza to branch nm09. - Commit Hook On Feb. 11, 2012, 7:02 a.m., Swami Dhyan Nataraj [Nikolay Shaplov] wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103921/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2012, 7:02 a.m.) > > > Review request for Network Management and Lamarque Vieira Souza. > > > Description > ------- > > In this part of code we do localize plan names, not providers. This patch > changes name of the list. It also would be good to rename > getProviderNameByLocale function, because it is used both for plans and > providers, but I am not quite familiar with naming tradition to choose the > name properly. > > > Diffs > ----- > > settings/config/mobileproviders.cpp > 0bee2b3eb75766d01f7235ccf0971d150a09bcff > > Diff: http://git.reviewboard.kde.org/r/103921/diff/diff > > > Testing > ------- > > > Thanks, > > Swami Dhyan Nataraj [Nikolay Shaplov] > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
