----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103950/#review10554 -----------------------------------------------------------
This review has been submitted with commit 8e2aa8b1a320e39aac2984532d31e25df0526422 by Lamarque V. Souza to branch master. - Commit Hook On Feb. 12, 2012, 3:05 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103950/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2012, 3:05 p.m.) > > > Review request for Network Management. > > > Description > ------- > > Two fixes: > 1. Fix the WEP key validator in WepAuthWidget > 2. Enable/disable OK button in ConnectionSecretsJob::doAskUser > > > Diffs > ----- > > libs/ui/connectionsecretsjob.cpp d87c47c > libs/ui/security/wepauthwidget.h 6ff721b > libs/ui/security/wepauthwidget.cpp 86b9711 > libs/ui/security/wirelesssecurityauth.cpp 1ebefba > > Diff: http://git.reviewboard.kde.org/r/103950/diff/ > > > Testing > ------- > > For change 2, WEP case is tested and working fine. WPA/WPA2 personal case is > lightly tested and doesn't seem to introduce any regression. It would be > great if anyone can test other encryption types. > > > Thanks, > > Rajeesh K Nambiar > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
