> On March 3, 2012, 1:57 p.m., Lamarque Vieira Souza wrote: > > libs/ui/vpnpreferences.cpp, line 73 > > <http://git.reviewboard.kde.org/r/104141/diff/2/?file=51665#file51665line73> > > > > It's ok now. > > > > I tried to test the patch but it seem NetworkManager is refusing to > > accept the route configuration from Plasma NM. That is not the fault of > > your patch but I cannot add new routes to test your patch. > > > > The message "NetworkManager[9513]: nm_ip4_route_set_prefix: assertion > > `prefix <= 32' failed" appears in the log when I try to add new routes (for > > examploe 192.168.2.0/255.255.255.0 through gateway 192.168.1.1). > > 255.255.255.0 == prefix 0 and 0 is < 32, I do not know why this is > > happening. It would be better if the error messages printed the wrong > > prefix, but whatever. > > > > I will have to fix that problem first before I can test your patch. > > Lamarque Vieira Souza wrote: > Nevermind, downgrading to NetworkManager 0.9.2.0 fixed the issue. Well, > NM is not doing so well, I used using a git version from 0.9.3 something, I > tried to upgrade to fix that problem but then NM 0.9.3.995 simply does not > start here. Downgrading was the solution. > > I tested your patch, it seems to work. Can you update the OpenVPN > export/import code to support this feature? can you provide a patch against > master too? > > Rajeesh K Nambiar wrote: > I see what's happening - if you change configuration file entry to > 192.168.2.0/24, it will work. You can see that in the IPV4 settings tab, > under Routes the netmask is set as 0.0.0.0 if 255.255.255.0 is used, which is > why NetworkManager refuses to add the connection. > > We should ideally do a sanity check on the address and prefix. I could > use SimpleIpV4AddressValidator to validate address. Any clue how to handle > 255.255.255.0 and 24 as same? Nothing helpful in QHostAdress class...
I do not see that. The gateway is set to 0.0.0.0 by default in Routes, not the netmask. Even after I changed it to 192.168.1.1 NM still refuses to add the route. Anyway, NM 0.9.2.0 works. There is already inputmasks for all entries in the dialog. - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104141/#review11104 ----------------------------------------------------------- On March 3, 2012, 1:43 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104141/ > ----------------------------------------------------------- > > (Updated March 3, 2012, 1:43 p.m.) > > > Review request for Network Management. > > > Description > ------- > > Import/Export Routes setting for VPN connections from/to configuration files. > Please review the Gateway/Metrics part in particular. > > > Diffs > ----- > > libs/ui/vpnpreferences.cpp 9afc6f2 > settings/config/manageconnectionwidget.cpp caa2e06 > vpnplugins/vpnc/CMakeLists.txt 5af39b9 > vpnplugins/vpnc/vpnc.cpp 79f62ec > > Diff: http://git.reviewboard.kde.org/r/104141/diff/ > > > Testing > ------- > > Tested the import/export part, Routes appear properly in the new connection. > I don't have a real configuration file to test :-/ > > > Thanks, > > Rajeesh K Nambiar > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
