----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104349/ -----------------------------------------------------------
Review request for Network Management and Lamarque Vieira Souza. Description ------- This is a kind of concept how to internationalize list of APNs in mobile connection wizard. This concept uses less CPU and more memory (through this task is not resourse critical). It create a list of apn's QVatiant map once, and then uses it all the time till the end. I thought it is better then reparse XML each time we need an APL info. If there are ant comments, I will try to do fixes. If no, and everything is OK, I will remove all commented out code from the patch, and let's commit it :-) Diffs ----- settings/config/mobileconnectionwizard.h 3cd801e92f1bf15acf7857192fac052107fdfe52 settings/config/mobileconnectionwizard.cpp b2e72d631b8272c4be5bdb8766a1d214715e2038 settings/config/mobileproviders.h 8df2269b38f7339d328de53e0be4734896bc1595 settings/config/mobileproviders.cpp 24d2c9256ebc87997e8a9f1903faa84900aa4d16 Diff: http://git.reviewboard.kde.org/r/104349/diff/ Testing ------- Thanks, Swami Dhyan Nataraj [Nikolay Shaplov]
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
