----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104979/ -----------------------------------------------------------
(Updated May 18, 2012, 11:27 p.m.) Review request for Network Management. Changes ------- Requested fixes pushed to both master and nm09 branches in the git tree, and new patch attached with post-review (I think). Thanks for the review. Description ------- This fixes three issues with the OpenConnect VPN support: - A pending connection attempt cannot be cancelled, occasionally causing kded to lock up while waiting for it. This has been reported by users when behind a captive portal which accepts HTTPS connections but never does anything else, causing the connection attempt never to complete. - The XML configuration file listing the available VPN servers was not being parsed correctly, and the originally configured server wasn't being de-duplicated from that list. - Selecting a host in the combobox did not start a connection. The post-review seems to have submitted all three in one patch; separate commits are at http://git.infradead.org/users/dwmw2/networkmanagement.git Tested against the Fedora 16 0.9.0.2 package, with OpenConnect 3.19 (and I'm about to release OpenConnect 3.20 because 3.19 introduced a stupid bug which occasionally breaks the KDE authentication dialog.) Is the nm09 branch still active? These patches seem to apply cleanly both to master and nm09. Diffs (updated) ----- vpnplugins/openconnect/openconnectauth.cpp 4f9cea7330b6004027df7acb0507fe902e112498 vpnplugins/openconnect/openconnectauthworkerthread.h dc251885c54e050daabe25f7be9e7af5d79bc785 vpnplugins/openconnect/openconnectauthworkerthread.cpp 23d8731a46dd3d7e89dafef2da5f7d90f309f8eb Diff: http://git.reviewboard.kde.org/r/104979/diff/ Testing ------- Connecting to $EMPLOYER's VPN, selecting different hosts from the list (now that the list works), and observing a successful cancellation instead of having to (press a button and) wait for the connection to complete each time. Thanks, David Woodhouse
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
