----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106437/#review18995 -----------------------------------------------------------
Ship it! Nice improvement. That one has been bugging me for a while, too. Bonus points for removing a C++ layout and moving it into a .ui. - Sebastian Kügler On Sept. 13, 2012, 9:52 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106437/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2012, 9:52 a.m.) > > > Review request for Network Management. > > > Description > ------- > > Fix a bug in which the wireless password prompt dialog would be shown at an > incorrect size > > Added a title and icon to the dialog so that it's clear when it pops up to the > user what the prompt is for. > > > Diffs > ----- > > libs/ui/CMakeLists.txt 42ae858 > libs/ui/security/wirelesssecurityauth.cpp b61d14a > libs/ui/security/wirelesssecurityauth.ui PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106437/diff/ > > > Testing > ------- > > Tested with multiple WPA and WEP connections. > > > Screenshots > ----------- > > After > http://git.reviewboard.kde.org/r/106437/s/726/ > Before > http://git.reviewboard.kde.org/r/106437/s/727/ > > > Thanks, > > David Edmundson > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
