----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108064/#review24614 -----------------------------------------------------------
libs/internals/settings/ipv6.h <http://git.reviewboard.kde.org/r/108064/#comment18877> code style, use "} else {" here instead of "} <line break> else {" libs/ui/ipv6widget.cpp <http://git.reviewboard.kde.org/r/108064/#comment18878> privacy can be const here. libs/ui/ipv6widget.cpp <http://git.reviewboard.kde.org/r/108064/#comment18876> code style, use "} else {" here instead of "} <line break> else {" libs/ui/ipv6widget.cpp <http://git.reviewboard.kde.org/r/108064/#comment18875> you can reuse the privacy variable here instead of calling d->setting->privacy() again. After those changes ship it. - Lamarque Vieira Souza On Jan. 3, 2013, 6:17 p.m., Ralf Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108064/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 6:17 p.m.) > > > Review request for Network Management. > > > Description > ------- > > This patch adds an option to the IPv6 configuration screen to change the IPv6 > Privacy Extension configuration. > > The option is implemented as documented at > http://projects.gnome.org/NetworkManager/developers/api/09/ref-settings.html > . However, that document says the default value is "-1", while it also says > that only 0, 1 and 2 are valid for this option. Therefore, I chose 0 to be > the default in the Knm::Ipv6Setting class, but the option is always put into > the NM config map - even if it is zero. > > > This addresses bug 312305. > http://bugs.kde.org/show_bug.cgi?id=312305 > > > Diffs > ----- > > backends/NetworkManager/settings/ipv6dbus.cpp 8c846ab > libs/internals/settings/ipv6.h 2eadf69 > libs/internals/settings/ipv6.cpp 590274b > libs/ui/ipv6.ui 56a1248 > libs/ui/ipv6widget.cpp 36b6885 > > Diff: http://git.reviewboard.kde.org/r/108064/diff/ > > > Testing > ------- > > I verified that whatever I configure in the applet ends up in the > /etc/NetworkManager/system-connections files. > > I could not yet test whether the extensions are actually properly enabled and > disabled because the network I am currently in does not use IPv6. However, > next week I will be at university again where I should be able to test this. > > > Thanks, > > Ralf Jung > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
