> On Feb. 13, 2013, 1:38 p.m., Lamarque Vieira Souza wrote: > > libs/ui/security/security8021xauth.cpp, line 58 > > <http://git.reviewboard.kde.org/r/108941/diff/1/?file=113890#file113890line58> > > > > I am wondering why needSecrets() returns empty. Long ago I added a hack > > to make sure it returns a non-empty QStringList, it seems something else is > > missing. Can you try the patch in http://paste.kde.org/670268/ without this > > patch applied and check if it also solves the problem? > > Jan Grulich wrote: > It returns an empty list, because in needSecrets() method is a condition > where we test if required password is empty, but it is not because it is > entered incorrectly.
Well, so this problem affects all connection types. needSecrets() should list all possible secrets when NetworkManager passes the RequestNew flag. We can add a bool parameter to needSecrets() indicating if it should list all possible secrets and them call needSecrets(pair.second & RequestNew) in SecretStorage::walletOpenedForRead(). That should fix the problem for all connection types. - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108941/#review27363 ----------------------------------------------------------- On Feb. 13, 2013, 11:02 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108941/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 11:02 a.m.) > > > Review request for Network Management and Lamarque Vieira Souza. > > > Description > ------- > > The dialog was created by the needed secrets. When the user entered the wrong > password then secrets were empty so we have to use another way to find out > what password we need. Tested on eduroam and it seems that it works without a > problem. > > > This addresses bug 299868. > http://bugs.kde.org/show_bug.cgi?id=299868 > > > Diffs > ----- > > libs/ui/security/security8021xauth.cpp 5c67355 > > Diff: http://git.reviewboard.kde.org/r/108941/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
