----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111814/#review37382 -----------------------------------------------------------
settings/bondsetting.h <http://git.reviewboard.kde.org/r/111814/#comment27653> Code style: macros comes first, please swap those two lines and all similar lines throughout the patch. This patch basically fixes a memory leak in the library: the classes that inherit from Settings and ConnectionSettings overrides the d_ptr from Settings and ConnectionSettings without deallocating its memory. I think we could avoid that and the waste of memory of allocating a SettingPrivate and ConnectionSettingPrivate by passing the *Private from the derived class to super class, like NetworkManager::Device does. There is a constructor in NetworkManager::Device with a DevicePrivate parameter just for that reason. - Lamarque Souza On Aug. 8, 2013, 6:50 a.m., Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111814/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 6:50 a.m.) > > > Review request for Network Management, Jan Grulich and Lamarque Souza. > > > Description > ------- > > As agreed with lamarque on IRC, we should try to resolve any pending BC > issues in libnm-qt before making its first official release. > > Cf > https://trello.com/c/cxR7AEAX/44-fix-binary-compatibiliy-issues-in-libmm-qt-and-libnm-qt > > > Diffs > ----- > > accesspoint.cpp d934d53 > activeconnection.h 7f6ed12 > adsldevice.cpp 34a19ef > bluetoothdevice.cpp 32f0d06 > bonddevice.cpp 25162e6 > bridgedevice.cpp 949913e > device.h d3e9084 > infinibanddevice.cpp 4fe4625 > modemdevice.cpp 4ee63d2 > olpcmeshdevice.cpp 06beabc > olpcmeshdevice_p.h 99eaa28 > settings/adslsetting.h c597ee5 > settings/bluetoothsetting.h 107f843 > settings/bondsetting.h 0f75cc5 > settings/bridgeportsetting.h 50b2261 > settings/bridgesetting.h dd0fa9e > settings/cdmasetting.h c2465cf > settings/gsmsetting.h 4307f2a > settings/infinibandsetting.h 49310ab > settings/ipv4setting.h 6bc1a97 > settings/ipv6setting.h 422865b > settings/olpcmeshsetting.h 8f5637b > settings/pppoesetting.h b2dd3d7 > settings/pppsetting.h cb82f8a > settings/security8021xsetting.h b681981 > settings/serialsetting.h 0a2dc9f > settings/setting.h d9b532d > settings/vlansetting.h f04cdd9 > settings/vpnsetting.h 1304664 > settings/wimaxsetting.h 0cccca2 > settings/wiredsetting.h f7af177 > settings/wirelesssecuritysetting.h 2578836 > settings/wirelesssetting.h 91d1d8e > vlandevice.cpp 8284428 > vpnconnection.cpp 18fe7d7 > vpnplugin.h 1aad58d > wimaxdevice.cpp b68c55c > wimaxnsp.cpp 90045ed > wireddevice.cpp 2ccc8d8 > wirelessdevice.cpp 1744023 > > Diff: http://git.reviewboard.kde.org/r/111814/diff/ > > > Testing > ------- > > Compiles fine, will be running it live from now on. > > > Thanks, > > Lukáš Tinkl > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
