----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118980/#review61111 -----------------------------------------------------------
vpn/vpnc/vpncadvanced.ui <https://git.reviewboard.kde.org/r/118980/#comment42556> Please add a tool tip like this here: <property name="toolTip"> <string>Local port to use (0-65535). 0 (default value) means random port. </string> </property> vpn/vpnc/vpncadvancedwidget.cpp <https://git.reviewboard.kde.org/r/118980/#comment42557> Code style: variables in camel case, use uintLocalportNum vpn/vpnc/vpncadvancedwidget.cpp <https://git.reviewboard.kde.org/r/118980/#comment42558> Well, usually all KDE code uses { in every if clause (even if it is one line only), like this: if (...) { } Yes, I know this file does not follow this rule, but please try following the code style [1] :-) [1] http://techbase.kde.org/Policies/Kdelibs_Coding_Style - Lamarque Souza On June 27, 2014, 10:11 p.m., Michal Malý wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118980/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 10:11 p.m.) > > > Review request for Network Management, Jan Grulich and Lukáš Tinkl. > > > Repository: plasma-nm > > > Description > ------- > > This trivial patch adds a spinbox to VPNC advanced settings widget that > allows the user to select which Local Port will the VPNC service try to bind. > > > Diffs > ----- > > vpn/vpnc/vpncadvanced.ui 1c541f4 > vpn/vpnc/vpncadvancedwidget.cpp 9f86c0e > > Diff: https://git.reviewboard.kde.org/r/118980/diff/ > > > Testing > ------- > > The setting seems to be saved and loaded properly. Wireshark logs show that > the correct Local Port is used. VPNC will use a random port if the value is > set to zero. > > > Thanks, > > Michal Malý > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
