-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119973/#review65725
-----------------------------------------------------------


Looks good to me, lamarque?

- Lukáš Tinkl


On Srp. 28, 2014, 3:16 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119973/
> -----------------------------------------------------------
> 
> (Updated Srp. 28, 2014, 3:16 odp.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> In the new release of plasma-nm we dropped support for plaintext files and 
> the only option where to store secrets with our secret agent is now KWallet, 
> but with dropping it, we kinda broke it for users who have secrets stored in 
> plaintext file. I wrote a patch which should re-save/migrate secrets stored 
> in plaintext files and save them either to KWallet (if enabled) or directly 
> to NetworkManager.
> 
> 
> Diffs
> -----
> 
>   kded/secretagent.h e821f59 
>   kded/secretagent.cpp 26f8faa 
> 
> Diff: https://git.reviewboard.kde.org/r/119973/diff/
> 
> 
> Testing
> -------
> 
> I tried to create a file with secrets (for vpn, wifi, gsm) manually and they 
> were successfuly transfered to KWallet.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

_______________________________________________
kde-networkmanager mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-networkmanager

Reply via email to