----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120483/#review67868 -----------------------------------------------------------
Ship it! Ship It! - Jan Grulich On Říj. 3, 2014, 4:58 odp., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120483/ > ----------------------------------------------------------- > > (Updated Říj. 3, 2014, 4:58 odp.) > > > Review request for Network Management and Jan Grulich. > > > Repository: plasma-nm > > > Description > ------- > > Since Plasma-NM just displays a single icon with a well-defined name > (network-foo-bar-123-baz) there's no need to use a custom SvgItem. > > Also, IconItem handles the icon size automatically removing the need for > units.roundToIconSize. BusyIndicator is square also and so anchors.fill > doesn't skew it. > > > Diffs > ----- > > applet/contents/ui/CompactRepresentation.qml 8c1dd68 > > Diff: https://git.reviewboard.kde.org/r/120483/diff/ > > > Testing > ------- > > Tested on WiFi, should probably be tested on mobile and VPN but I don't see > why this should cause trouble. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
