----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121467/#review71885 -----------------------------------------------------------
Do not use classes like KComboBox, KLineEdit or KDialog, those are removed in KDE Frameworks 5. I also don't think you managed to compile this. You need to compile master branch of libnm-qt first (you can see how to compile it in README). Also your plugin is in plasma-2/vpn subdirectory, it should be directly in vpn directory. Before you submit a new version of your patch try to format it according to https://techbase.kde.org/Policies/Kdelibs_Coding_Style. plasma-nm-2/vpn/sstp/plasmanetworkmanagement_sstpui.desktop <https://git.reviewboard.kde.org/r/121467/#comment50098> You can add yourself here plasma-nm-2/vpn/sstp/plasmanetworkmanagement_sstpui.desktop <https://git.reviewboard.kde.org/r/121467/#comment50099> Same here plasma-nm-2/vpn/sstp/sstp.cpp <https://git.reviewboard.kde.org/r/121467/#comment50100> Use K_PLUGIN_FACTORY_WITH_JSON as other VPN plugins do. This even doesn't compile. plasma-nm-2/vpn/sstp/sstp.cpp <https://git.reviewboard.kde.org/r/121467/#comment50101> This can be removed. plasma-nm-2/vpn/sstp/sstpauth.ui <https://git.reviewboard.kde.org/r/121467/#comment50104> Use QLineEdit instead KLineEdit. plasma-nm-2/vpn/sstp/sstpprop.ui <https://git.reviewboard.kde.org/r/121467/#comment50105> Use QLineEdit instead of KLineEdit. plasma-nm-2/vpn/sstp/sstpprop.ui <https://git.reviewboard.kde.org/r/121467/#comment50107> Use QLineEdit. plasma-nm-2/vpn/sstp/sstpprop.ui <https://git.reviewboard.kde.org/r/121467/#comment50109> Use QLineEdit. plasma-nm-2/vpn/sstp/sstpprop.ui <https://git.reviewboard.kde.org/r/121467/#comment50110> Use QComboBox. plasma-nm-2/vpn/sstp/sstpprop.ui <https://git.reviewboard.kde.org/r/121467/#comment50112> Use QLineEdit. plasma-nm-2/vpn/sstp/sstpwidget.h <https://git.reviewboard.kde.org/r/121467/#comment50114> Use QComboBox instead of KComboBox. plasma-nm-2/vpn/sstp/sstpwidget.cpp <https://git.reviewboard.kde.org/r/121467/#comment50115> Use QDialog instead of KDialog. plasma-nm-2/vpn/sstp/sstpwidget.cpp <https://git.reviewboard.kde.org/r/121467/#comment50117> Coding style. https://techbase.kde.org/Policies/Kdelibs_Coding_Style - Jan Grulich On Pro. 12, 2014, 4:23 odp., William Boren wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121467/ > ----------------------------------------------------------- > > (Updated Pro. 12, 2014, 4:23 odp.) > > > Review request for Network Management and Jan Grulich. > > > Repository: plasma-nm > > > Description > ------- > > Added support for SSTP VPN in plasma-nm (GCI task) > > > Diffs > ----- > > plasma-nm-2/vpn/sstp/CMakeLists.txt PRE-CREATION > plasma-nm-2/vpn/sstp/Messages.sh PRE-CREATION > plasma-nm-2/vpn/sstp/sstp.h PRE-CREATION > plasma-nm-2/vpn/sstp/sstp.cpp PRE-CREATION > plasma-nm-2/vpn/sstp/sstpadvanced.ui PRE-CREATION > plasma-nm-2/vpn/sstp/sstpauth.h PRE-CREATION > plasma-nm-2/vpn/sstp/sstpauth.cpp PRE-CREATION > plasma-nm-2/vpn/sstp/sstpauth.ui PRE-CREATION > plasma-nm-2/vpn/sstp/sstpprop.ui PRE-CREATION > plasma-nm-2/vpn/sstp/sstpwidget.h PRE-CREATION > plasma-nm-2/vpn/sstp/sstpwidget.cpp PRE-CREATION > plasma-nm-2/vpn/sstp/nm-sstp-service.h PRE-CREATION > plasma-nm-2/vpn/sstp/plasmanetworkmanagement_sstpui.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121467/diff/ > > > Testing > ------- > > > Thanks, > > William Boren > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
