----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125543/#review86447 -----------------------------------------------------------
Ship it! Ship It! - Lamarque Souza On Oct. 7, 2015, 11:52 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125543/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 11:52 a.m.) > > > Review request for Network Management and Lamarque Souza. > > > Repository: plasma-nm > > > Description > ------- > > While adding tooltips to our editor for OpenVPN properties I noticed that we > are missing options for few properties which are already implemented in > nm-connection-editor and also that we have different names for some options. > This patch adds those missing properties and changes some labels so they > match NM implementation. I also fixed some coding style issues and used > QLatin1String where it was possible. > > > Diffs > ----- > > vpn/openvpn/nm-openvpn-service.h 39e2251 > vpn/openvpn/openvpn.ui b68e27e > vpn/openvpn/openvpnadvanced.ui 687d7d1 > vpn/openvpn/openvpnadvancedwidget.cpp fe63958 > > Diff: https://git.reviewboard.kde.org/r/125543/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
