----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126715/#review90875 -----------------------------------------------------------
src/activeconnection.cpp (line 150) <https://git.reviewboard.kde.org/r/126715/#comment62086> You missed deleteLater() here. src/activeconnection.cpp (line 184) <https://git.reviewboard.kde.org/r/126715/#comment62085> You could create a common method called from both constructors instead of duplicating this code in them. - Lamarque Souza On Jan. 11, 2016, 9:58 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126715/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 9:58 a.m.) > > > Review request for Network Management and Lamarque Souza. > > > Bugs: 352326 > http://bugs.kde.org/show_bug.cgi?id=352326 > > > Repository: networkmanager-qt > > > Description > ------- > > Previous review request: 126029 > > My previous solution doesn't seem to work, probably because I was sending > signals from constructor. I changed this to asynchronous calls so signals > should be now emitted when ActiveConnection is properly constructed. > > > Diffs > ----- > > src/activeconnection.cpp f29ca67 > > Diff: https://git.reviewboard.kde.org/r/126715/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
