----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127172/#review92751 -----------------------------------------------------------
Looks good, but branch 0.9.3 is already unmaintained. Is the same patch necessary in Plasma 5? I don't remember having this problem with OpenVPN/VPNC password dialogs and not sure right now if PPTP is different in this. - Jan Grulich On Úno. 24, 2016, 11:05 odp., Tomasz Bywalec wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127172/ > ----------------------------------------------------------- > > (Updated Úno. 24, 2016, 11:05 odp.) > > > Review request for Network Management. > > > Repository: plasma-nm > > > Description > ------- > > PPTP authentication dialog: focus is now automatically set on "password" > textbox. > > Also: > > * The dialog's width is now the same as width of OpenVPN authentication > dialog. > * "Show password" checkbox is now aligned to the left. > > ================================================================================= > > Motivation for this change: > > 1. User experience: when keyboard focus is automatically set on "password" > textbox, then user can start entering password immediately when the dialog is > displayed. > > 2. Consistency of look&behaviour between PPTP and OpenVPN authentication > dialogs. > > > Diffs > ----- > > vpn/pptp/pptpauth.cpp a2b1255 > vpn/pptp/pptpauth.ui 86bbdb8 > > Diff: https://git.reviewboard.kde.org/r/127172/diff/ > > > Testing > ------- > > Tested on Slackware64-current. > > > Thanks, > > Tomasz Bywalec > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
