----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128486/#review97607 -----------------------------------------------------------
vpn/openvpn/openvpnadvancedwidget.h (line 49) <https://git.reviewboard.kde.org/r/128486/#comment65797> Please, ignore this. I first though that the option "adaptive" for --comp-lzo is new only in OpenVPN 2.3 and I wanted to get first OpenVPN version and then use this option only in case of latest OpenVPN. Then I found out it's there for years and removed that part of code and this line is leftover. - Jan Grulich On Čec. 19, 2016, 12:10 odp., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128486/ > ----------------------------------------------------------- > > (Updated Čec. 19, 2016, 12:10 odp.) > > > Review request for Network Management and Lamarque Souza. > > > Bugs: 365816 > http://bugs.kde.org/show_bug.cgi?id=365816 > > > Repository: plasma-nm > > > Description > ------- > > Since OpenVPN 2.1, the option --comp-lzo allows more choices then "yes" or > "no" and we should handle that. See > https://community.openvpn.net/openvpn/wiki/Openvpn23ManPage. Currently > NetworkManager-openvpn supports that only in the plugin, but doesn't expose > that in their UI which shouldn't be a problem. > > > Diffs > ----- > > vpn/openvpn/openvpnadvanced.ui 9bfab83 > vpn/openvpn/openvpnadvancedwidget.h 9fc2465 > vpn/openvpn/openvpnadvancedwidget.cpp 3253e3b > > Diff: https://git.reviewboard.kde.org/r/128486/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
