----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/ -----------------------------------------------------------
(Updated Zář. 6, 2016, 11:56 dop.) Review request for KDE Frameworks, Network Management and Lamarque Souza. Changes ------- We need to also call ActiveConnection::propertiesChanged() for VpnConnection which iherits from it, otherwise we won't be notified about changed state and so on. Repository: networkmanager-qt Description ------- Since NM 1.2.x they switched to using o.f.DBus.Properties for sending PropertiesChanged signal. They still support their previous solution which uses their o.f.NetworkManager.Foo interfaces, but with release of NM 1.4.0 this is a bit broken (altough already fixed in upstream). With the fix for that they marked PropertiesChanged signal for their o.f.NM.Foo interfaces as deprecated and we should be slowly moving towards the standardized o.f.DBus.Properties interface instead. See https://bugzilla.gnome.org/show_bug.cgi?id=770629 Diffs (updated) ----- src/accesspoint.cpp d1abe31 src/accesspoint_p.h bf111c8 src/activeconnection.cpp fc8a1ac src/activeconnection_p.h d021437 src/adsldevice.cpp f07b5e6 src/bluetoothdevice.cpp 3ccf276 src/bonddevice.cpp d9798b0 src/bridgedevice.cpp f345ad5 src/connection.cpp 5b80a93 src/connection_p.h 5f43d93 src/device.cpp f7bc7e6 src/device_p.h da85faf src/dhcp4config.cpp efcd98d src/dhcp4config_p.h ce5563c src/dhcp6config.cpp 4f0a3b6 src/dhcp6config_p.h 093f234 src/genericdevice.cpp a6919d5 src/gredevice.cpp 1f81ea4 src/infinibanddevice.cpp 15b3575 src/macvlandevice.cpp db2c594 src/manager.cpp 01723d7 src/manager_p.h d0a9d8c src/modemdevice.cpp 89394f0 src/olpcmeshdevice.cpp 286a080 src/settings.cpp f75b86a src/settings_p.h 466d0a7 src/teamdevice.cpp 543d26d src/tundevice.cpp 68eb103 src/vethdevice.cpp bb7c9fd src/vlandevice.cpp 415dec9 src/vpnconnection.cpp d2d17e4 src/vpnconnection_p.h 25ba589 src/wimaxdevice.cpp daec0a6 src/wireddevice.cpp af147b1 src/wirelessdevice.cpp dad918d Diff: https://git.reviewboard.kde.org/r/128843/diff/ Testing ------- Thanks, Jan Grulich
