----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129212/#review100107 -----------------------------------------------------------
libs/editor/widgets/passwordfield.h (line 24) <https://git.reviewboard.kde.org/r/129212/#comment67234> KLineEdit is deprecated for QLineEdit libs/editor/widgets/passwordfield.h (line 25) <https://git.reviewboard.kde.org/r/129212/#comment67235> QComboBox ? - Anthony Fieroni On Oct. 18, 2016, 9:01 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129212/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 9:01 a.m.) > > > Review request for Network Management, KDE Usability, Albert Astals Cid, and > Lamarque Souza. > > > Repository: plasma-nm > > > Description > ------- > > As discussed over email, currently the password options (Save, Not Required, > Always ask) are not easy to find so we decided to move them back to separated > combobox again, ecept moving the combobox below the password field with a > better description. > >  > > > Diffs > ----- > > libs/editor/settings/cdmawidget.cpp 309b6e6 > libs/editor/settings/gsmwidget.cpp de5a7ef > libs/editor/settings/pppoewidget.cpp 1305797 > libs/editor/settings/security802-1x.cpp e5f0307 > libs/editor/settings/wifisecurity.cpp fc607eb > libs/editor/widgets/passwordfield.h 627d9b0 > libs/editor/widgets/passwordfield.cpp 68aa3b8 > vpn/openvpn/openvpnadvancedwidget.cpp 1dea814 > vpn/openvpn/openvpnwidget.cpp 5241883 > vpn/pptp/pptpwidget.cpp dabaa25 > vpn/sstp/sstpwidget.cpp f0bf10a > vpn/vpnc/vpncwidget.cpp 7c547f9 > > Diff: https://git.reviewboard.kde.org/r/129212/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
