----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100777/#review1727 -----------------------------------------------------------
That looked simple :-) Does it work when you remove an account "normally" through the accounts KCM? The way I read this it will call onAccountRemoved and then emit removed(), but the Tp::Account will also be emitting removed anyway, which means account-item will emit removed() (if that makes sense) Because of this I think remove() will get emitted twice. Try taking out line 167 of account-item.cpp and it should all behave nicely. - David On March 1, 2011, 9:21 p.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100777/ > ----------------------------------------------------------- > > (Updated March 1, 2011, 9:21 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Remove an account from the list as it gets removed by some other app like > empathy. > > > Diffs > ----- > > src/account-item.cpp 20709790b89bc79780371b7823462d00815db05c > > Diff: http://git.reviewboard.kde.org/r/100777/diff > > > Testing > ------- > > * open the kcm module and empathy > * remove an account in empathy and see it being deleted from the kcm > > > Thanks, > > Florian > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
