----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100776/#review1831 -----------------------------------------------------------
Ship it! Very minor comments. Also if making visual changes - it's worth including a screenshot like you did on some other reviews. haze/haze-myspaceim-account-ui.cpp <http://git.reviewboard.kde.org/r/100776/#comment1503> This should be <KCMTelepathyAccounts/ParameterEditModel> also where possible try and group the includes, so that all the KCMTelepathy ones are together. In fact - if it's only used for debugging - consider taking it (and the debugging 57-59) out. haze/myspaceim-advanced-settings-widget.ui <http://git.reviewboard.kde.org/r/100776/#comment1502> This should be 65535. Source: Google for maximum port number - David On March 7, 2011, 5:21 p.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100776/ > ----------------------------------------------------------- > > (Updated March 7, 2011, 5:21 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Add MySpaceIM (myspace) support to haze plugin. > > > Diffs > ----- > > haze/myspaceim-main-options-widget.ui PRE-CREATION > haze/myspaceim-main-options-widget.cpp PRE-CREATION > haze/myspaceim-main-options-widget.h PRE-CREATION > haze/myspaceim-advanced-settings-widget.ui PRE-CREATION > haze/myspaceim-advanced-settings-widget.cpp PRE-CREATION > haze/myspaceim-advanced-settings-widget.h PRE-CREATION > haze/haze-myspaceim-account-ui.cpp PRE-CREATION > haze/haze-myspaceim-account-ui.h PRE-CREATION > haze/haze-account-ui-plugin.cpp 0bc48fd294ad9ef5cb45a3dbb311649723ba0465 > haze/CMakeLists.txt 96476e72ca62efcce3933031b4400e2bc7070a72 > > Diff: http://git.reviewboard.kde.org/r/100776/diff > > > Testing > ------- > > * add account > * connect > > note: if you create a new account from scratch, you need to use pidgin to set > your username, telepathy-haze does not support this atm. > > > Thanks, > > Florian > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
