----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100825/#review1865 -----------------------------------------------------------
Ship it! Few minor comments, up to you on whether you want to implement them. app/chat-window.cpp <http://git.reviewboard.kde.org/r/100825/#comment1526> Rather than && !duplicateTab; you could just call "break;" in the part of the code where you've found a duplicate. Whichever looks easiest to read. app/chat-window.cpp <http://git.reviewboard.kde.org/r/100825/#comment1525> I know I said using return was fine, but in this case saying: if (!auxChatWidget) continue; might be better. That way we'll always see any new tabs even if something has gone disastrously wrong, and it doesn't have any bad side effects. - David On March 9, 2011, 6:52 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100825/ > ----------------------------------------------------------- > > (Updated March 9, 2011, 6:52 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Simple patch to avoid creating duplicate chat tabs > > > Diffs > ----- > > app/chat-window.h b023241 > app/chat-window.cpp 66f7c03 > app/telepathy-chat-ui.cpp 776c148 > lib/chat-widget.h 95d4eb6 > lib/chat-widget.cpp 753de62 > > Diff: http://git.reviewboard.kde.org/r/100825/diff > > > Testing > ------- > > Tested it by adding three tabs and then requesting the same three tabs again. > As expected i was show the already opened chat tab and no new tab was created. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
