----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100843/#review1951 -----------------------------------------------------------
Ship it! - David On March 11, 2011, 11:50 p.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100843/ > ----------------------------------------------------------- > > (Updated March 11, 2011, 11:50 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Don't use or include GenericAdvancedOptionsWidget where not needed. > > If there is only one tab/page of advanced options it just wraps everything in > a tabwidget for no reason. > > > Diffs > ----- > > salut/salut-account-ui.cpp 37799f8ced61f0167c23337e8539d947b6d71b5b > rakia/rakia-account-ui.cpp dee381991e9b944391259e172432b44c16b3d8bf > haze/haze-yahoo-account.cpp 8841c597a88a87ac2a6c3ca91a9f26b3a813a4c6 > haze/haze-icq-account.cpp 51d0cd73010dba97024194c18d219df7cf716b3c > > Diff: http://git.reviewboard.kde.org/r/100843/diff > > > Testing > ------- > > * compiled > * launched the kcm plugin and opened all my configured accounts. > > > Thanks, > > Florian > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
