----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100867/#review1990 -----------------------------------------------------------
lib/adium-theme-message-info.cpp <http://git.reviewboard.kde.org/r/100867/#comment1669> It's ever so slightly quicker to run .replace('\t', ...) rather than .replace("\t", as it's replacing a single QChar rather than a string Note: replace(" ") with two spaces still needs the double quotes, as that's more than one character and is therefore a string. - David On March 15, 2011, 11:52 p.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100867/ > ----------------------------------------------------------- > > (Updated March 15, 2011, 11:52 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > If you send "foo bar" the html widget used to render as "foo bar". > replacing " " by fixes this. > > > Diffs > ----- > > lib/adium-theme-message-info.cpp 60e379b468b2e29b6d3f09e5b889960a3e727585 > > Diff: http://git.reviewboard.kde.org/r/100867/diff > > > Testing > ------- > > Just works™ :) > > > Screenshots > ----------- > > message with leading spaces, leading tabs and a really long line with > multiple spaces > http://git.reviewboard.kde.org/r/100867/s/102/ > > > Thanks, > > Florian > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
