> On March 16, 2011, 2:49 a.m., David Edmundson wrote: > > lib/adium-theme-view.cpp, line 49 > > <http://git.reviewboard.kde.org/r/100866/diff/2/?file=11456#file11456line49> > > > > Why is there a - sign to the left of KIconLoader::SizeLarge ? > > Florian Reinhard wrote: > because i spent more than an hour with "why does iconPath return an empty > string" and then found this in the docs of KIconLoader: > > > QString KIconLoader::iconPath (const QString & name, > int group_or_size, > bool canReturnNull = false > ) > > group_or_size If positive, search icons whose size is specified by > the icon group group_or_size. If negative, search icons whose size is - > group_or_size. See KIconLoader::Group and KIconLoader::StdSizes
I'm not sure I understand that, but well done on fixing it. Add a note next to that bit of code because I'm sure every person who looks at it is going to ask the same question. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100866/#review1988 ----------------------------------------------------------- On March 16, 2011, 12:36 a.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100866/ > ----------------------------------------------------------- > > (Updated March 16, 2011, 12:36 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Show a default icon (im-user.png) in the text-ui when there is no avatar. > > > This addresses bug 268547. > http://bugs.kde.org/show_bug.cgi?id=268547 > > > Diffs > ----- > > lib/adium-theme-view.h b98409958af9a59e29e30d478b80ec548c8fad5a > lib/adium-theme-view.cpp 1eefafb5e64f31f75b21568d8924a6398dcafd25 > > Diff: http://git.reviewboard.kde.org/r/100866/diff > > > Testing > ------- > > started a conversation, both icons for received and sent messages are shown. > > > Thanks, > > Florian > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
