----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100886/#review2034 -----------------------------------------------------------
Ship it! I think you've mixed up a few other bits of code/review in here. The approach I go for is to do the following: git checkout master git checkout -b mynewfeature do some work commit it git checkout master git checkout -b myothernewfeature . . . If your second feature really does depend on the first branch, when you make a a diff run post-review --parent=mynewfeature, so the diff only covers the actual changes. (hope that all makes sense) lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/100886/#comment1707> I assume this part is the only part that's of this change. Makes sense to me. - David On March 18, 2011, 11:33 a.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100886/ > ----------------------------------------------------------- > > (Updated March 18, 2011, 11:33 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Let's save some cpu cylcles and don't detect typing in chat-widget when we > can't use it. > > > Diffs > ----- > > config/kcm_telepathy_chat_config.desktop > 7641c3a2af38ffd0c426185461bc82aa3f95fcb2 > lib/adium-theme-view.cpp 0133f3d0309147083a91773be37d72d016ace08d > lib/chat-widget.cpp 6ea639b0b3696030bd76bba219522abf70aef400 > lib/chat-window-style.cpp e5003ec7acf1f02e6eed178773aafc02dad82228 > > Diff: http://git.reviewboard.kde.org/r/100886/diff > > > Testing > ------- > > no more warnings like this on cli: > tp-qt4 0.5.11.1 WARN: TextChannel::requestChatState() used with no chat state > interface > > > Thanks, > > Florian > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
