> On March 24, 2011, 1:10 p.m., Francesco Nwokeka wrote: > > lib/channel-contact-model.cpp, line 44 > > <http://git.reviewboard.kde.org/r/100940/diff/1/?file=12799#file12799line44> > > > > are the parenthesis here for a "one-liner" really neccessary?
Yup, that's what the kdelibs coding style says -- http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Braces - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100940/#review2147 ----------------------------------------------------------- On March 24, 2011, 2:58 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100940/ > ----------------------------------------------------------- > > (Updated March 24, 2011, 2:58 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > If there are more than 1 other contact in a group chat show a list of these > users in a sidebar. > > > Diffs > ----- > > lib/CMakeLists.txt 5dc3f74aede922597ced7a7a2229fa141b3372ea > lib/channel-contact-list.h 37f29e6305c96a1aa9f3a30a2eabb141139f33f5 > lib/channel-contact-list.cpp 2eccee0a852e47d90a74a518adcc9260e1c8cef7 > lib/channel-contact-model.h PRE-CREATION > lib/channel-contact-model.cpp PRE-CREATION > lib/chat-widget.cpp 6ea639b0b3696030bd76bba219522abf70aef400 > lib/chat-widget.ui 173e1151bf04c8573525ff193adffb7129df808a > > Diff: http://git.reviewboard.kde.org/r/100940/diff > > > Testing > ------- > > Opened a chat, saw that some people were there. > > > Thanks, > > David > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
