----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100963/#review2207 -----------------------------------------------------------
app/chat-window.cpp <http://git.reviewboard.kde.org/r/100963/#comment1832> I should have spotted this last time. Please use KStandardAction http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/namespaceKStandardAction.html#ac8479803082dd0e38f0c34221070add9 KStandardAction::find(this, SLOT(onSearchActionToggled), this); It automatically sets the correct key, icon and has the advantage that a user can configure the keys globally. app/chat-window.cpp <http://git.reviewboard.kde.org/r/100963/#comment1833> standardaction::findnext app/chat-window.cpp <http://git.reviewboard.kde.org/r/100963/#comment1834> you can probably guess what this comment will be... - David On March 28, 2011, 2:04 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100963/ > ----------------------------------------------------------- > > (Updated March 28, 2011, 2:04 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > ~ Added the default "find-next" and "find-previous" keyboard shortcuts to > iterate over the find function in the chat-ui. > ~ Changed comment as requested by mck182 in previous commit > > > Diffs > ----- > > app/chat-window.h aacfcef > app/chat-window.cpp 3b79498 > lib/chat-search-bar.h 6bed1b3 > lib/chat-search-bar.cpp 8fff36e > lib/chat-widget.h 02140f7 > lib/chat-widget.cpp 9083c3d > > Diff: http://git.reviewboard.kde.org/r/100963/diff > > > Testing > ------- > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
