----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100972/#review2246 -----------------------------------------------------------
Ship it! It is definitely a strange situation, and I will have a better look. If the superclass is under our control, the approach I'd choose is to have both implicitly shared, and have the private data pointer to be privately inherited by the subclass, which would somehow make the situation more sustainable. But for now, this change is definitely fine. - Dario On March 30, 2011, 8:51 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100972/ > ----------------------------------------------------------- > > (Updated March 30, 2011, 8:51 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Fixes a bug in which calls to > AdiumThemeMessageInfo a = someOtherMessageInfo class failed to actually copy > all the information. > > This appears a bug in the config window as found by Florian Reinhard: > https://git.reviewboard.kde.org/r/100922/ > > > Diffs > ----- > > lib/adium-theme-content-info.cpp a5e1d6780ccf65acd70a024648955f621457eb65 > lib/adium-theme-status-info.cpp b2568e05a534f8d59bb82220043d9ff0dfb88aff > > Diff: http://git.reviewboard.kde.org/r/100972/diff > > > Testing > ------- > > > Thanks, > > David > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
