----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100970/#review2249 -----------------------------------------------------------
First of all, awesome job on this one. A pair of comments follow cmake/modules/FindGIO.cmake <http://git.reviewboard.kde.org/r/100970/#comment1901> As per KDE policy, we should copyright those files under a BSD license (have a look in kdelibs/cmake/modules). If you copy-pasted this from tp-qt4, feel free to assign the copyright to me, otherwise I guess you wrote it, and eternal glory should be yours :) lib/glib/CMakeLists.txt <http://git.reviewboard.kde.org/r/100970/#comment1902> I actually don't like that - why are we installing headers for the glib library? Ideally in the test library we should try and handle tp-glib internally, and expose high-level methods. I don't know if this is meant as a temporary workaround or it has become compulsory for some things you want to do. - Dario On March 29, 2011, 8:06 p.m., George Goldberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100970/ > ----------------------------------------------------------- > > (Updated March 29, 2011, 8:06 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Resync the glib CM's with upstream and make sure everything still builds. > > > Diffs > ----- > > CMakeLists.txt 24e033ad6162196f207c0211c69ccf869f7f1b51 > cmake/modules/FindGIO.cmake PRE-CREATION > lib/KTelepathyTestLibConfig.cmake.in > fb358e0402c4c51e13ae7fedea95d458a40810ba > lib/glib/CMakeLists.txt 85249502c690e3ff8ed3c5ec64bdc49aa20e07f5 > lib/glib/bug-19101-conn.h PRE-CREATION > lib/glib/bug-19101-conn.c PRE-CREATION > lib/glib/bug16307-conn.h PRE-CREATION > lib/glib/bug16307-conn.c PRE-CREATION > lib/glib/contacts-conn.h 39e87fbb84d973d88f4170d6254efc009568736d > lib/glib/contacts-conn.c 47997dba87d91dbdcd1387e8048a6401c659acb2 > lib/glib/echo-chan.h PRE-CREATION > lib/glib/echo-chan.c PRE-CREATION > lib/glib/echo-cm.h PRE-CREATION > lib/glib/echo-cm.c PRE-CREATION > lib/glib/echo-conn.h PRE-CREATION > lib/glib/echo-conn.c PRE-CREATION > lib/glib/echo-im-manager.h PRE-CREATION > lib/glib/echo-im-manager.c PRE-CREATION > lib/glib/myassert.h PRE-CREATION > lib/glib/params-cm.c a0b1820cffcbb744d47decb4e0afa7f4a06b1aee > lib/glib/simple-account.c 2674f71bbbdc0e31c94c4bf73bd3915473ef5f73 > lib/glib/simple-channel-dispatcher.h PRE-CREATION > lib/glib/simple-channel-dispatcher.c PRE-CREATION > lib/glib/simple-channel-request.h PRE-CREATION > lib/glib/simple-channel-request.c PRE-CREATION > lib/glib/simple-conn.h 12204dda0dd8c44f47c1da31ec72f36ed4c75767 > lib/glib/simple-conn.c 1c981896555198c4f60bae784b06e836fadff23e > lib/glib/simple-manager.h 2edf213944a850c1a55b1f8a4b641019ed0f15b3 > lib/glib/simple-manager.c d1592cfca2a582f52605b83319465a9cf0c5846f > lib/glib/stream-tube-chan.h PRE-CREATION > lib/glib/stream-tube-chan.c PRE-CREATION > lib/glib/stub-object.h PRE-CREATION > lib/glib/stub-object.c PRE-CREATION > lib/glib/textchan-group.h 61e1c0c66d6bf00333bf6134b43ecd295e42bbb3 > lib/glib/textchan-group.c 6a6f5d7f3d11a4f982d1e37e831f1720cb7e5a89 > lib/glib/textchan-null.h 163dec68d4617d4070e3a702eb80ca388eaa9263 > lib/glib/textchan-null.c 48857f95874c5ea0c6ebf044d050b0bdaa2a91dd > lib/glib/util.h d3433ccf9c108dbd57391ebd7ac5c0a5d76872c3 > lib/glib/util.c 4dbec7bb28b7b317862c3be6896c4edc774781bd > > Diff: http://git.reviewboard.kde.org/r/100970/diff > > > Testing > ------- > > Stuff builds :) > > > Thanks, > > George > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
