----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100948/#review2251 -----------------------------------------------------------
Ship it! Even though you submitted it already, I'm marking some small things I see you have done in other reviews you submitted, so that you can avoid doing them in the future! app/chat-window.cpp <http://git.reviewboard.kde.org/r/100948/#comment1904> Use i18nc() to add some context when text might be ambiguous (like in this case), otherwise translators will come and hunt you! :) app/chat-window.cpp <http://git.reviewboard.kde.org/r/100948/#comment1905> Code style: if ( (always use spaces) lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/100948/#comment1906> Code style: emit signal(), and not emit(signal()) - Dario On March 26, 2011, 1:29 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100948/ > ----------------------------------------------------------- > > (Updated March 26, 2011, 1:29 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Implementation of "search" within the chat window. > The search widget is called via keyboard shortcut ( standard "ctrl+f ") and > can also be modified by the user from the chat settings. > > > This addresses bug 269052. > http://bugs.kde.org/show_bug.cgi?id=269052 > > > Diffs > ----- > > app/chat-window.h cde19e4 > app/chat-window.cpp b3407db > lib/CMakeLists.txt 1639cfd > lib/chat-widget.h dfdef64 > lib/chat-widget.cpp 5ddf3dd > lib/chat-widget.ui 2dce82f > > Diff: http://git.reviewboard.kde.org/r/100948/diff > > > Testing > ------- > > wrote in a chat and looked for random text. Please try the patch and tell me > if some functionality is missing > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
