----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100455/#review2252 -----------------------------------------------------------
Ship it! As the change has not been marked as submitted (do so if it has been), nitpicking on some small things src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <http://git.reviewboard.kde.org/r/100455/#comment1907> If you do not need ordered values (like it appears to be in this case), use QHash instead of QMap - it is slightly faster. src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <http://git.reviewboard.kde.org/r/100455/#comment1908> Code style: if ( - Dario On March 24, 2011, 8:18 p.m., Thomas Richard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100455/ > ----------------------------------------------------------- > > (Updated March 24, 2011, 8:18 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch will give some visible feedback in a non obtrusive way. There is > also the possibility to provide some custom validation on parameters using > the ParameterEditModel. > > The screenshots speak a 1000 words ;) > > > Diffs > ----- > > src/KCMTelepathyAccounts/CMakeLists.txt > 51389226299db38012f7f326b3e57709f4d3e244 > src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp > 9f5b0d4f9b27c0502783895ee0f52e320829ffc3 > src/KCMTelepathyAccounts/account-edit-widget.h > 11d80778e4ed0fc7f80943d2248d3f08b27feb20 > src/KCMTelepathyAccounts/account-edit-widget.cpp > 5c09e5dade33ae383d63827add757c8688c24fb7 > src/KCMTelepathyAccounts/feedback-widget.h PRE-CREATION > src/KCMTelepathyAccounts/feedback-widget.cpp PRE-CREATION > src/KCMTelepathyAccounts/include/ValidatedLineEdit PRE-CREATION > src/KCMTelepathyAccounts/parameter-edit-model.h > d904facc2c958440d193fe86182bd50c0ee6721f > src/KCMTelepathyAccounts/parameter-edit-model.cpp > 441b6e58daf13b3fcf65ab344544ae36e50b940b > src/KCMTelepathyAccounts/validated-line-edit.h PRE-CREATION > src/KCMTelepathyAccounts/validated-line-edit.cpp PRE-CREATION > src/add-account-assistant.h 973bad46e11697135c331c632e9cb63dcb790232 > src/add-account-assistant.cpp eb9a644d38b0020ce3158c99f3714dddd1b8047a > src/edit-account-dialog.cpp bcfaca26ec9fbf8385b4d43d2c673319c8bdc9a9 > > Diff: http://git.reviewboard.kde.org/r/100455/diff > > > Testing > ------- > > When all parameters are valid, an account still gets added > > > Screenshots > ----------- > > Valid email address > http://git.reviewboard.kde.org/r/100455/s/56/ > Invalid email address > http://git.reviewboard.kde.org/r/100455/s/57/ > Invalid email address and clicking apply > http://git.reviewboard.kde.org/r/100455/s/58/ > When an account did not get accepted by telepathy itself > http://git.reviewboard.kde.org/r/100455/s/59/ > > > Thanks, > > Thomas > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
