> On March 31, 2011, 12:09 a.m., David Edmundson wrote: > > lib/adium-theme-view.cpp, line 30 > > <http://git.reviewboard.kde.org/r/100979/diff/1/?file=13513#file13513line30> > > > > QtGui/QFontDatabase > > > > I've been told it's always better to include things like this, though I > > don't understand why. > > Florian Reinhard wrote: > fixed.
This actually makes sense only when talking about headers, as some config scripts do not include all of the Qt subdirectories. In non-exported files it is perfectly fine to include stuff without the module prefix (even though I still like to add it, as it looks nicer). - Dario ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100979/#review2266 ----------------------------------------------------------- On March 31, 2011, 10:55 a.m., Florian Reinhard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100979/ > ----------------------------------------------------------- > > (Updated March 31, 2011, 10:55 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch makes font family and size configureable. It currently uses two > methods to achieve this: > * Set the default font for the QWebView > * Add some extra css to make the user setting actually do something in case > the theme does hardcode the font-family in it's css files and does not use > relative font sizes. > > As noted on the code, this patch also includes a check whether the default > font requested by the theme is installed on the user's system which for now > lacks a warning which should be shown to the user. > > > This addresses bug 265704. > http://bugs.kde.org/show_bug.cgi?id=265704 > > > Diffs > ----- > > config/chatwindowconfig.ui a24b789c6c40fa665cefbbfa997997cda970e1c4 > config/main-window.h 1eb2030653f4702de934b1f47c383aff7cc8e556 > config/main-window.cpp d74de0b87d98585ea3314597b7a9401ae8fd4eb9 > lib/adium-theme-view.h 920e06208ea7f6cef23054c4a1ddf52ed02aa420 > lib/adium-theme-view.cpp b7a88f850de1f71e453f99b11dc98642dc18ccb0 > lib/chat-window-style.h 3ca12a8a00b406ba0bf79af4ec4baab86d853ba5 > lib/chat-window-style.cpp 33f6c35f6e7539e14718dd563eab9c6966210632 > > Diff: http://git.reviewboard.kde.org/r/100979/diff > > > Testing > ------- > > installed some themes, seems to work. the css approach for sure needs to be > improved since just altering html div elements won't do the trick for all > themes. > > > Screenshots > ----------- > > default (in this case fallback) font > http://git.reviewboard.kde.org/r/100979/s/110/ > custom font > http://git.reviewboard.kde.org/r/100979/s/111/ > > > Thanks, > > Florian > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
