----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101012/#review2316 -----------------------------------------------------------
Will you also do the full dialog for the user info? CMakeLists.txt <http://git.reviewboard.kde.org/r/101012/#comment1999> Why is this added? CMakeLists.txt <http://git.reviewboard.kde.org/r/101012/#comment2006> Are we using KIO now? main-widget.cpp <http://git.reviewboard.kde.org/r/101012/#comment2007> As per IRC discussion, please remove this (it has been redone) :) main-widget.cpp <http://git.reviewboard.kde.org/r/101012/#comment2000> This could use KIconLoader::global()->iconPath(...) Same for that bunch of lines below. main-widget.cpp <http://git.reviewboard.kde.org/r/101012/#comment2002> This should probably have backslashes before the quotes, ie. "width=\"16\"". main-widget.cpp <http://git.reviewboard.kde.org/r/101012/#comment2003> Again the \". Does it actually work like that? main-widget.cpp <http://git.reviewboard.kde.org/r/101012/#comment2001> I don't like the i18n here, change it to pure QString and add that i18n just as another arg, ie. QString("<td><img src="%1" height="16" width="16" /> <b>%3</b> %2<br />", cmIconPath, displayName, i18n("Account:")); main-widget.cpp <http://git.reviewboard.kde.org/r/101012/#comment2004> Why is there so much ? If it is already a table, can't it be aligned with td? main-widget.cpp <http://git.reviewboard.kde.org/r/101012/#comment2005> Ok, please discard this whole method as I redid this with a different approach :) - Martin On April 2, 2011, 6:42 p.m., Keith Rusler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101012/ > ----------------------------------------------------------- > > (Updated April 2, 2011, 6:42 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > - Added support for tooltips when hovering over a contact in the list. > - Added support for the avatar button at the top of the contact list. > Now it will load the avatar when connecting, though I'm not sure on > how to handle it if a protocol changed the avatar outside of telepathy. > If the avatar is big it will resize it, so you don't have a huge tooltip > when you hover your accounts. > > > Diffs > ----- > > CMakeLists.txt 7581f10 > main-widget.h daa6559 > main-widget.cpp f65d7fd > > Diff: http://git.reviewboard.kde.org/r/101012/diff > > > Testing > ------- > > > Thanks, > > Keith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
