----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101031/#review2400 -----------------------------------------------------------
Much better, still a few tiny issues to sort out. src/KCMTelepathyAccounts/account-edit-widget.h <http://git.reviewboard.kde.org/r/101031/#comment2061> I know I told you to put this here, but actually this class has a private class for storing all it's private variables in. (read up on d pointers if you want to learn why some people do it.) and as such this needs to go in the public section of AccountEditWidget::Private (around account-edit-widget.cpp line 55) then accessed with d->connectOnAdd; src/KCMTelepathyAccounts/account-edit-widget.cpp <http://git.reviewboard.kde.org/r/101031/#comment2060> Though now you have a new issue If I ran: AccountEditWidget widget(profile, mode, false); widget.connectOnAdd(); We have a crash. (not that anyone should, but it's still bad) Make sure m_connectOnAdd is initialised to 0, and then put a check around this code making it return false if m_connectOnAdd doesn't exist. - David On April 5, 2011, 3:12 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101031/ > ----------------------------------------------------------- > > (Updated April 5, 2011, 3:12 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Add a option to let the user go online with his new account as soon as he > adds it. > > > This addresses bug 269911. > http://bugs.kde.org/show_bug.cgi?id=269911 > > > Diffs > ----- > > src/KCMTelepathyAccounts/account-edit-widget.h 8e0c7ea > src/KCMTelepathyAccounts/account-edit-widget.cpp 5c09e5d > src/add-account-assistant.cpp e038e8b > src/edit-account-dialog.cpp 2772c61 > > Diff: http://git.reviewboard.kde.org/r/101031/diff > > > Testing > ------- > > Patch compiles and works as described above, i could see my account go online > as soon as i added it, and when the tick box was unchecked, the account did > not connect > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/101031/s/112/ > > > Thanks, > > Rohan > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
