> On April 7, 2011, 8:58 p.m., David Edmundson wrote: > > main-widget.cpp, line 839 > > <http://git.reviewboard.kde.org/r/101048/diff/2/?file=13927#file13927line839> > > > > ReadWrite?
My bad. It was initially a different buffer. > On April 7, 2011, 8:58 p.m., David Edmundson wrote: > > main-widget.cpp, line 796 > > <http://git.reviewboard.kde.org/r/101048/diff/2/?file=13927#file13927line796> > > > > foreach(const Tp::AccountPtr &account... Fixed. > On April 7, 2011, 8:58 p.m., David Edmundson wrote: > > main-widget.cpp, line 787 > > <http://git.reviewboard.kde.org/r/101048/diff/2/?file=13927#file13927line787> > > > > do you need to pass account Ids about? it's better to just pass > > AccountrPtrs if possible. > > > > You can use AccountManager::accountForPath() What is that path exactly? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101048/#review2478 ----------------------------------------------------------- On April 7, 2011, 5:15 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101048/ > ----------------------------------------------------------- > > (Updated April 7, 2011, 5:15 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch adds initial avatars support plus KConfig, which holds the > selected avatar. > > > Diffs > ----- > > main-widget.h e310b35d475509f5683a0abe15f21bbb1d8f122e > CMakeLists.txt 548e8c880b5ef921606c7407b92e2e1650faef86 > accounts-model-item.cpp 1d207e7eebb6d286d0fc075dfa4e90628ac92bcc > main-widget.cpp 2e049a13561a1dc4ca0b7117a52ed713d775b9bd > main-widget.ui bc1fb9bf030a927cf635ed1f73d71d6ee33675b2 > main.cpp aac4f4b98f8ad809fd6380b45be793fdbcae8814 > > Diff: http://git.reviewboard.kde.org/r/101048/diff > > > Testing > ------- > > Tried to change the avatar and it worked. > > > Screenshots > ----------- > > Avatars menu > http://git.reviewboard.kde.org/r/101048/s/114/ > > > Thanks, > > Martin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
