----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101012/#review2483 -----------------------------------------------------------
Ship it! That looks really clear. I have onecomment below, I may be wrong, but at least double check before merging. +1 from me. P.S in future try to put in a screenshot for any visual change. contact-delegate.cpp <http://git.reviewboard.kde.org/r/101012/#comment2152> you sure this should return false? from the docs: "Returns true if the delegate can handle the event; otherwise returns false. A return value of true indicates that the data obtained using the index had the required role. " - David On April 7, 2011, 10:27 p.m., Keith Rusler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101012/ > ----------------------------------------------------------- > > (Updated April 7, 2011, 10:27 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > - Added support for tooltips when hovering over a contact in the list. > - Added support for the avatar button at the top of the contact list. > Now it will load the avatar when connecting, though I'm not sure on > how to handle it if a protocol changed the avatar outside of telepathy. > If the avatar is big it will resize it, so you don't have a huge tooltip > when you hover your accounts. > > > Diffs > ----- > > contact-delegate.h 20daa62 > contact-delegate.cpp 73f37e4 > main-widget.cpp 7bde815 > > Diff: http://git.reviewboard.kde.org/r/101012/diff > > > Testing > ------- > > > Thanks, > > Keith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
