----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101066/#review2518 -----------------------------------------------------------
Very good patch one quick comment below. I'm waiting for Martin Klapetek to approve the patch as he's lead on the contact list. contact-delegate.cpp <http://git.reviewboard.kde.org/r/101066/#comment2210> Not sure this is 100% right. You've changed the color to be lighter. However, when it starts fading the color goes back to being QPalette::WindowText and then starts changing the alpha. Which means when it fades it will start off grey (it's normal color), then go to black before fading. - David On April 9, 2011, 12:43 p.m., Lukas Hetzenecker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101066/ > ----------------------------------------------------------- > > (Updated April 9, 2011, 12:43 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Lighter color for status message > Show presence type if status message is not set > > > Diffs > ----- > > contact-delegate.cpp 89514d2 > > Diff: http://git.reviewboard.kde.org/r/101066/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/101066/s/119/ > > > Thanks, > > Lukas > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
