> On April 12, 2011, 1:28 p.m., David Edmundson wrote: > > Code is fine (except a minor comment below). > > > > I'm still not 100% convinced by your design for presence stuff, and how it > > interacts with 3rd parties changing the presence. However I'll wait till > > it's finished before judging. > >
Any hints for improvement? ;) > On April 12, 2011, 1:28 p.m., David Edmundson wrote: > > main-widget.h, line 89 > > <http://git.reviewboard.kde.org/r/101104/diff/1/?file=14218#file14218line89> > > > > Does this really need to be public? > > > > In general make things protected/private unless there's actually a > > reason to make it public. The idea is to be able to trigger this slot by eventual config interface (pressing Apply in the dialog). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101104/#review2581 ----------------------------------------------------------- On April 12, 2011, 1:10 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101104/ > ----------------------------------------------------------- > > (Updated April 12, 2011, 1:10 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch saves the presence message so it stays when you reopen the contact > list. > > > Diffs > ----- > > main-widget.h 18f97ee > main-widget.cpp 7fe200c > > Diff: http://git.reviewboard.kde.org/r/101104/diff > > > Testing > ------- > > Status message set, app reopened, status message still present > > > Thanks, > > Martin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
