> On April 13, 2011, 3:50 p.m., David Edmundson wrote: > > lib/chat-widget.cpp, line 313 > > <http://git.reviewboard.kde.org/r/101105/diff/3/?file=14246#file14246line313> > > > > In future make sure you do each change in a separate branch. It means > > you can commit one fix without waiting on another. (and you don't mix up > > your reviews!)
Oh. No, actually it seems I forgot to commit the change to my separate branch (I don't know if I even staged it), then did git diff HEAD^. The latest pulled commit was mine, too (because I did this on other machine with another git clone), so... :) Yes, separate branches are amazing. Thanks, I have to pay better attention in the future. - Lasse ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101105/#review2615 ----------------------------------------------------------- On April 13, 2011, 8:23 a.m., Lasse Liehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101105/ > ----------------------------------------------------------- > > (Updated April 13, 2011, 8:23 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > I'm not sure about the message, but there should be some. Ideas about a > better message are really appreciated. I'm also not sure if the line: > statusMessage.setService(d->channel->connection()->protocolName()); > is good or not. I don't know what "service" is used for. > > > This addresses bug 270725. > http://bugs.kde.org/show_bug.cgi?id=270725 > > > Diffs > ----- > > lib/chat-widget.h fdf5ccd > lib/chat-widget.cpp af7edff > > Diff: http://git.reviewboard.kde.org/r/101105/diff > > > Testing > ------- > > 1. Open a text chat with someone > 2. Chat > 3. Go offline (don't close the chat window/tab) > 4. Send message line edit and button are disabled, informational message is > shown > > > Thanks, > > Lasse > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
