> On April 14, 2011, 7:03 a.m., Francesco Nwokeka wrote: > > contact-delegate.cpp, line 301 > > <http://git.reviewboard.kde.org/r/101118/diff/1/?file=14363#file14363line301> > > > > Here you hardcoded the avatar values. What happens to the avatar if I > > don't have a square avatar, but a rectangular one? > > I think the aspect ratio gets messed up
Also it would be better 96x96 (as that's rather regular icon size) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101118/#review2621 ----------------------------------------------------------- On April 14, 2011, 1:37 a.m., Keith Rusler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101118/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 1:37 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > - Fixes some lines of code > - Resizes the avatars in the tooltips to 97x97 > - Adds a default icon for contacts that don't have an avatar > As requested by bug: 270492 > > > This addresses bug 270492. > http://bugs.kde.org/show_bug.cgi?id=270492 > > > Diffs > ----- > > contact-delegate.cpp 89514d2 > > Diff: http://git.reviewboard.kde.org/r/101118/diff > > > Testing > ------- > > This adds a default avatar (im-user) to the tooltips and is resized to 97x97 > to keep the tooltips at a suggested size that will keep decent. If it was any > smaller, the tooltips would just look really weird similar to ones that don't > have a default status message. > > > Screenshots > ----------- > > Default Avatar Tooltips > http://git.reviewboard.kde.org/r/101118/s/127/ > > > Thanks, > > Keith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
