----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101134/#review2807 -----------------------------------------------------------
I think this code has a really easy to make flaw, (that I know about my doing it wrong myself a few times) other than that it's good (even if you are showing off a bit with your QtConcurrents..) main-widget.cpp <http://git.reviewboard.kde.org/r/101134/#comment2449> It's possible for the account to be ready and connected before the ContactManager is ready (ContactListStateSuccess). At which point allKnownContacts() returns an empty list if you use it too early. I think this code falls into that trap, at which point we may miss contacts that were added whilst we were offline. - David On April 21, 2011, 1:34 p.m., Dario Freddi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101134/ > ----------------------------------------------------------- > > (Updated April 21, 2011, 1:34 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This is a simple hack to make contact list aware of new presence subscription > requests. It consists of a modal dialog - in a bright future where this will > be moved out, it will be displayed as a KNotification instead. To ease the > user's life, on acceptance the request is accepted and a subscription is made > (a-la-windows live). > > > This addresses bug 270665. > http://bugs.kde.org/show_bug.cgi?id=270665 > > > Diffs > ----- > > main-widget.h 9180d64de553487de089d7ef907b444dc742a92f > main-widget.cpp 305a453f5162e688e28b9345eada3cfaecea2325 > > Diff: http://git.reviewboard.kde.org/r/101134/diff > > > Testing > ------- > > Briefly tested and working, needs more testing. > > > Thanks, > > Dario > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
