> On April 22, 2011, 4:15 p.m., Dario Freddi wrote: > > Awesome job, to me it looks perfect. Please wait for David or Martin to > > give you the final word before pushing that in though.
Sorry, I forgot one thing: the fact that when a user closes the bar, he probably does not want it to be pinned anymore. New patch below ;) - Rémy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101181/#review2824 ----------------------------------------------------------- On April 22, 2011, 4:19 p.m., Rémy Greinhofer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101181/ > ----------------------------------------------------------- > > (Updated April 22, 2011, 4:19 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Adding a button to the filter bar to define if this latter must be pinned or > not to the contact list next time this one is launched. > > > This addresses bug 270476. > http://bugs.kde.org/show_bug.cgi?id=270476 > > > Diffs > ----- > > filter-bar.cpp 13102f5 > main-widget.cpp a100c05 > filter-bar.h 9546c63 > > Diff: http://git.reviewboard.kde.org/r/101181/diff > > > Testing > ------- > > 1. Launch telepathy-contactlist, show the filter bar, check the pin button at > the left, close the contact list, relaunch it, the filter bar appears. > 2. Then uncheck the pin button at the left, close the contact list, relaunch > it, the filter bar does not appear. > > > Thanks, > > Rémy > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
