----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101186/ -----------------------------------------------------------
Review request for Telepathy. Summary ------- Updated parameter edit model to keep track of profile parameters Removed work around that set default value on first creation based on profile parameter. Disable non-editable edit fields where the value comes from a profile Diffs ----- src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp d28b4f3fed227aa2b15342f4b9312c02b8babea9 src/KCMTelepathyAccounts/parameter-edit-model.h ecd04e7b2aa7670a89b5fbf264c177df27c9057b src/KCMTelepathyAccounts/parameter-edit-model.cpp 441b6e58daf13b3fcf65ab344544ae36e50b940b src/KCMTelepathyAccounts/parameter-item.h 047aa57a6c8499b9e2619dc5b9b4f6bdc483ef6a src/KCMTelepathyAccounts/parameter-item.cpp c7d827ab923c302a8942bd75c276118f8f19882a src/add-account-assistant.cpp e038e8bf3256c2e99f755fdc0dd2945117833c91 src/edit-account-dialog.cpp bcfaca26ec9fbf8385b4d43d2c673319c8bdc9a9 Diff: http://git.reviewboard.kde.org/r/101186/diff Testing ------- Created a Facebook account, made sure defaults were filled in, and are now greyed out (disabled) for server/port. A normal jabber account has no defaults and is all editable. Thanks, David
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
