----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101228/#review2877 -----------------------------------------------------------
Ship it! That all seems to make a lot of sense. Though at some point we should possibly consider how we're going to present this "changeable display name" to the user, instead of leaving FIXMEs in. - David On April 24, 2011, 11:46 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101228/ > ----------------------------------------------------------- > > (Updated April 24, 2011, 11:46 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > When an account is modified, the display name is not updated, so if the > account is modified, the display name will show the old account name instead > of the new one. > This patch updates the display name every time the parameters are updated > (using the same displayName value used in add-account-assistant.cpp:170) > > > Diffs > ----- > > src/edit-account-dialog.h 35db80366717ae6b71b8b94637612b5dca06d251 > src/edit-account-dialog.cpp edf41bf7f11030467b4a25bbcdb865048bcef3bb > > Diff: http://git.reviewboard.kde.org/r/101228/diff > > > Testing > ------- > > Builds, and display name is modified when the account is modified. > > > Thanks, > > Daniele Elmo > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
