----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101255/#review2977 -----------------------------------------------------------
Ship it! Pretty much a perfect patch. Genuinely pleased. Hope part III is just as good. lib/chat-widget.h <http://git.reviewboard.kde.org/r/101255/#comment2549> const Tp::TextChannelPtr &newTextChannelPtr (before Dario spots it) - David On April 30, 2011, 1:40 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101255/ > ----------------------------------------------------------- > > (Updated April 30, 2011, 1:40 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > If a textChannel is invaldiated by the user going offline and then, once back > online, requests a chat with the same person, the channel is re-established. > > > Diffs > ----- > > app/chat-window.cpp 3d14909 > lib/chat-widget.h f7d08d3 > lib/chat-widget.cpp ef4927c > > Diff: http://git.reviewboard.kde.org/r/101255/diff > > > Testing > ------- > > started chat, went offline and back online, reopened chat with same contact. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
