> On April 23, 2011, 11:41 a.m., David Edmundson wrote: > > As long as it still works (check it, because I've been wrong when making > > comments before), ship it! > > Rémy Greinhofer wrote: > It still behaves the same way, thefefore I think it is good ;)
Do you have a dev account or shall we commit this for you? - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101190/#review2844 ----------------------------------------------------------- On April 23, 2011, 11:38 a.m., Rémy Greinhofer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101190/ > ----------------------------------------------------------- > > (Updated April 23, 2011, 11:38 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > After second though, we decided a button to pin/unpin the filter bar was not > necessary. The filter bar will simply be shown if it was when the contact > list was closed and vice-versa. > > > Diffs > ----- > > filter-bar.h 2acb724 > filter-bar.cpp 1d04ca8 > main-widget.cpp 4b877ab > > Diff: http://git.reviewboard.kde.org/r/101190/diff > > > Testing > ------- > > 1. Use the filter bar, close the contact list, relaunch the contact list. The > filter bar is shown. > 2. Then close the filter bar, close the contact list, relaunch the contact > list. The filter bar disappeared. > > It works if you use the close button of the filter bar, as well as the search > contact button. > > > Thanks, > > Rémy > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
