----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101288/#review3114 -----------------------------------------------------------
Ship it! main-widget.cpp <http://git.reviewboard.kde.org/r/101288/#comment2660> You pressed the spacebar too late :P --> if (!conn... - Martin On May 4, 2011, 4:09 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101288/ > ----------------------------------------------------------- > > (Updated May 4, 2011, 4:09 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Check for connection being valid rather than looking at the connection status > before calling monitor presence. > > There are times when connectionStatus is Connected, but account->connection() > returns 0. This causes crashes in the old code. > > Converted code to call monitorPresence when connectionChanges() not > connectionStatusChanges. > > Also updated monitorPresence to take a connectionPtr rather than accountPtr > as it makes the code easier with this new change. > > > Diffs > ----- > > main-widget.h c103a66e4c92b93a933fe02c82b5462c09740e85 > main-widget.cpp b929572ff47e7fc4a34e385525d0aab458909ffb > > Diff: http://git.reviewboard.kde.org/r/101288/diff > > > Testing > ------- > > Reconnected a few accounts. Didn't crash. > > > Thanks, > > David > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
